Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new command: knowledge edit #139

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Conversation

pavel-georgiev
Copy link
Contributor

Description

The edit command allows you to edit an existent knowledge object in the the editor defined by EDITOR environment variable, or fall back to 'vi' for Linux/MacOS or 'notepad' for Windows.`,

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@codecov-commenter
Copy link

Codecov Report

Merging #139 (23a55e3) into main (dae6f72) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #139   +/-   ##
=======================================
  Coverage   32.33%   32.33%           
=======================================
  Files          27       27           
  Lines        3569     3569           
=======================================
  Hits         1154     1154           
  Misses       2324     2324           
  Partials       91       91           

@pavel-georgiev pavel-georgiev force-pushed the fk-edit branch 2 times, most recently from 594553c to 2d2ae57 Compare July 6, 2023 00:14
Copy link
Contributor

@bemidji3 bemidji3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pnickolov pnickolov merged commit 2ead439 into cisco-open:main Jul 12, 2023
7 checks passed
GDW1 pushed a commit to GDW1/fsoc that referenced this pull request Jul 13, 2023
Co-authored-by: Pavel Georgiev <p3l@appdynamics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants