Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update optimize configure to set deployment UID on optimizer Orion config object #140

Conversation

linkous8
Copy link
Contributor

@linkous8 linkous8 commented Jul 6, 2023

Description

In order to create FMM entities associated with the deployment under optimization, the ARO backend needs to have the UID of the relevant deployment. This update writes deployment UID to a new field within the optimizer configuration object so that it can be used by the backed in its entity creation.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

on optimizer Orion config object
@linkous8 linkous8 requested a review from pnickolov as a code owner July 6, 2023 20:06
@codecov-commenter
Copy link

Codecov Report

Merging #140 (7e6bed5) into main (dae6f72) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #140   +/-   ##
=======================================
  Coverage   32.33%   32.33%           
=======================================
  Files          27       27           
  Lines        3569     3569           
=======================================
  Hits         1154     1154           
  Misses       2324     2324           
  Partials       91       91           

@pnickolov pnickolov merged commit 6c7914f into cisco-open:main Jul 6, 2023
7 checks passed
GDW1 pushed a commit to GDW1/fsoc that referenced this pull request Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants