Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and enable "solution push --subscribe" #141

Merged
merged 1 commit into from
Jul 9, 2023

Conversation

pavel-georgiev
Copy link
Contributor

Description

  • Unhide --subscribe flag
  • Fix issue when --subscribe is used with --wait
  • Do not allow --subscribe with --solution-bundle
  • Remove double print of messages upon subscribe
  • Make subscription retries more resiliant (up to 4 retries with backoff)

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

 * Unhide --subscribe flag
 * Fix issue when --subscribe is used with --wait
 * Do not allow --subscribe with --solution-bundle
 * Remove double print of messages upon subscribe
 * Make subscription retries more resiliant (up to 4 retries with backoff)
@codecov-commenter
Copy link

Codecov Report

Merging #141 (06c37ad) into main (6c7914f) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #141   +/-   ##
=======================================
  Coverage   32.33%   32.33%           
=======================================
  Files          27       27           
  Lines        3569     3569           
=======================================
  Hits         1154     1154           
  Misses       2324     2324           
  Partials       91       91           

@pnickolov pnickolov merged commit c152ff6 into cisco-open:main Jul 9, 2023
7 checks passed
GDW1 pushed a commit to GDW1/fsoc that referenced this pull request Jul 10, 2023
* Unhide --subscribe flag
 * Fix issue when --subscribe is used with --wait
 * Do not allow --subscribe with --solution-bundle
 * Remove double print of messages upon subscribe
 * Make subscription retries more resiliant (up to 4 retries with backoff)

Co-authored-by: Pavel Georgiev <p3l@appdynamics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants