Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating golang version to 1.20 #153

Merged
merged 3 commits into from
Aug 5, 2023

Conversation

Neo2308
Copy link
Member

@Neo2308 Neo2308 commented Jul 16, 2023

Description

  • Start using go version 1.20 which is necessary for using latest goreleaser

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

* Use go version 1.20
@Neo2308 Neo2308 requested a review from pnickolov as a code owner July 16, 2023 13:28
@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2023

Codecov Report

Merging #153 (c278aa0) into main (6523417) will decrease coverage by 0.41%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #153      +/-   ##
==========================================
- Coverage   32.08%   31.67%   -0.41%     
==========================================
  Files          27       28       +1     
  Lines        3597     3643      +46     
==========================================
  Hits         1154     1154              
- Misses       2352     2398      +46     
  Partials       91       91              

see 1 file with indirect coverage changes

* Use latest goreleaser version
* Fix goreleaser version to v1.19.2 (latest)
@pnickolov pnickolov merged commit 9a74750 into cisco-open:main Aug 5, 2023
6 checks passed
@Neo2308 Neo2308 deleted the feature/use_go_1.20 branch August 13, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants