Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSOC-168: fix issue with fsoc ks get not automatically paginating result set #171

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

bemidji3
Copy link
Contributor

Description

Noticed that the fsoc ks get command was not passing IsCollection: true when calling cmdkit.FetchAndPrint and this was causing issues with some users who were trying to get all of the objects in the get all output.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@bemidji3 bemidji3 requested a review from pnickolov as a code owner July 25, 2023 23:06
@codecov-commenter
Copy link

Codecov Report

Merging #171 (8b1bf02) into main (2adf4de) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #171   +/-   ##
=======================================
  Coverage   31.66%   31.66%           
=======================================
  Files          28       28           
  Lines        3644     3644           
=======================================
  Hits         1154     1154           
  Misses       2399     2399           
  Partials       91       91           

@pnickolov pnickolov merged commit 5b069be into cisco-open:main Aug 8, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants