Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/handling typed attributes in melt #172

Merged
merged 2 commits into from
Aug 7, 2023

Conversation

k-shaikh
Copy link
Contributor

Description

This addresses the handling of attribute types in the fsoc melt subcommands. This includes changes in

  • platform/types.go to support Attributes of any value not just string.
  • platform.exporter.go to map to correct OTEL type based on the Attribute value type
  • "fsoc melt model" to generate the yaml values with proper types based on attribute type in entity definition .

Type of Change

  • [X ] Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • [ X] I have read the contributing guidelines
  • [ X] Existing issues have been referenced (where applicable)
  • [X ] I have verified this change is not present in other open pull requests
  • Functionality is documented
  • [ X] All code style checks pass
  • [ X] New code contribution is covered by automated tests
  • [ X] All new and existing tests pass

@k-shaikh k-shaikh requested a review from pnickolov as a code owner July 26, 2023 18:36
@pnickolov pnickolov merged commit ebb6ae8 into main Aug 7, 2023
7 checks passed
@pnickolov pnickolov deleted the feature/handling-typed-attributes-in-melt branch August 7, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants