Optserv 582 implement fsoc support for events recommendations #176
Conversation
* example text added * Fix LIMIT->LIMITS uql syntax * Handle count larger than uql max page size * Skip pagination when count specified * Fix infinite loop due to redeclaring variable inside while loop
- added nil pointer check in extractEventsData to prevent panics
| Limits string | ||
| } | ||
|
|
||
| var eventsTemplate = template.Must(template.New("").Parse(` |
There was a problem hiding this comment.
AFAIK results are not guaranteed to be ordered, you can add this to force an order (important when you also have a limit):
ORDER
events.desc()
There was a problem hiding this comment.
I ended up having to use events.asc() for the ordering so that the latest events would show up at the bottom of the list which I find to be more readable and also important for the --follow implementation.
However this creates a complication with the --count parameter in that it no longer gets the latest n events. Instead it gets the first n events to occur after the SINCE boundary. Ultimately I think I will need to propose an update to output.go to allow reversing the order of the table being printed but want to get events merged in as is for now.
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #176 +/- ##
=======================================
Coverage 31.66% 31.66%
=======================================
Files 28 28
Lines 3644 3644
=======================================
Hits 1154 1154
Misses 2399 2399
Partials 91 91 |
Description
Implementation for new commands
fsoc optimize eventsandfsoc optimize recommendations.Type of Change
Checklist