DE14689 add support to reconnect kafka cluster admin #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into kafka-webhook
SonarQube Quality Gate |
![engit-sonar-int-gen-gpk[bot]](https://avatars1.githubusercontent.com/u/38261864?s=88&v=4){kind=small}
bseto
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix DE14689 sarama cluster admin lost kafka connection after 10 min.
kafka.metadata.refresh-frequency: 300sfor sarama kafka client's built inbackgroundMetadataUpdatertask (client.conf.Metadata.RefreshFrequency) as mentioned in: producer write broken pipe IBM/sarama#1565backgroundMetadataUpdatertask cannot keep the kafka connection alive for ClusterAdmin(ClusterAdmin uses different broker connection from the ones used inbackgroundMetadataUpdater). As a workaroundReloadClusterAdminhas been added so service can recreate ClusterAdmin instance when the connection is broken/lost.CloseProducerto close dynamic producers created in webhook service to reduce resource usage.