try building a shrinked version of the tcp metadata module

cisco-open · Jun 21, 2023 · 7a6dd2a · 7a6dd2a
1 parent 72abad6
commit 7a6dd2a
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 4 deletions.
diff --git a/.github/workflows/acceptance-test.yaml b/.github/workflows/acceptance-test.yaml
@@ -47,7 +47,7 @@ jobs:
 
       - name: Build TCP metadata exchange filter
         run: |
-          make tcp-metadata-exchange-filter
+          make tcp-metadata-exchange-filter-shrinked
 
       - name: Deploy to kind cluster (istio-operator)
         run: |

diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -46,7 +46,7 @@ jobs:
 
       - name: Build TCP metadata exchange filter
         run: |
-          make tcp-metadata-exchange-filter
+          make tcp-metadata-exchange-filter-shrinked
 
       - name: Run unit tests
         run: make test

diff --git a/Makefile b/Makefile
@@ -58,3 +58,9 @@ tcp-metadata-exchange-filter:	## build the tcp-metadata-exchange-filter
 	rustup target add wasm32-unknown-unknown
 	cargo build --target wasm32-unknown-unknown --release
 	cp target/wasm32-unknown-unknown/release/wasm_tcp_metadata.wasm pkg/istio/filters/tcp-metadata-exchange-filter.wasm
+
+.PHONY: tcp-metadata-exchange-filter-shrinked
+tcp-metadata-exchange-filter-shrinked: ## build the smaller version of tcp-metadata-exchange-filter 
+	rustup target add wasm32-unknown-unknown
+	cargo +nightly build -Z build-std=std,panic_abort -Z build-std-features=panic_immediate_abort -j1 --release --target wasm32-unknown-unknown
+	cp target/wasm32-unknown-unknown/release/wasm_tcp_metadata.wasm pkg/istio/filters/tcp-metadata-exchange-filter.wasm
diff --git a/experimental/wasm-tcp-metadata/README.md b/experimental/wasm-tcp-metadata/README.md
@@ -19,6 +19,12 @@ rustup component add rust-src --toolchain nightly-aarch64-apple-darwin
 Optimalize the binary size of the created module even further by running:
 
 ```bash
+# Install wasm-opt
+cargo install wasm-opt --locked
+```
+
+```bash
+# Optimize for size
 wasm-opt -Os target/wasm32-unknown-unknown/release/wasm_tcp_metadata.wasm -o target/wasm32-unknown-unknown/release/wasm_tcp_metadata.wasm
 ```
 
@@ -31,7 +37,7 @@ git clone git@github.com:istio-ecosystem/wasm-extensions.git
 cd wasm-extensions
 ```
 
-Now start a Bazel container (use the specified image version, other versions simply don't work on Mac, and ARM:
+Now start a Bazel container (use the specified image version, other versions simply don't work on Mac, and ARM):
 
 ```bash
 docker run -v $PWD:/tmp/work -w /tmp/work --rm -it --entrypoint bash gcr.io/bazel-public/bazel:5.4.0
@@ -44,4 +50,4 @@ build '//extensions/stats:stats.wasm' # This takes some time if you are on an AR
 cp bazel-bin/extensions/stats/stats.wasm .
 ```
 
-You can find the stats.wasm now in your `wasm-extensions` working directory.
+You can find the `stats.wasm` now in your `wasm-extensions` working directory.