Type usage consistency, braces, etc. #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulej
force-pushed
the
paulej_int_changes
branch
3 times, most recently
from
238ee95
to
6502f01
Compare
pabuhler
reviewed
Jan 15, 2024
pabuhler
reviewed
Jan 15, 2024
pabuhler
approved these changes
Jan 15, 2024
|
This is the last big part of #671 |
paulej
force-pushed
the
paulej_int_changes
branch
from
6502f01
to
b10e1df
Compare
pabuhler
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a number of changes to further use bool, size_t, ssize_t, etc. consistently through the code. I also added braces around single-line if() and for() statements. (As an aside, I actually like one-line statements, but when the clang-format rules force the line to break, I think braces should be employed. I'd be OK if we changed the clang-format file so that one-line statements stayed on a single line.)