Split get_skill_config into more specific functions. #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The get_skill_config method previously attempted to handle a number of cases such as when config doesn't exist, getting a config for specific skill, or getting all skill configurations. This resulted in the introduction of a bug in PR #50 where the init command attempted to determine if a skill with the passed in name already existed. The get_skill_config method would make an empty default configuration if one didn't exist, but seeing a name passed in would then attempt to read from that empty value and throw an error. This resulted in a new user being unable to initialize a project. To hopefully avoid other issues in the future the 4 functions previously contained in the get_skill_config method have been split into their own smaller methods which the commands can make use of as needed.
|
Fixes #52 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The get_skill_config method previously attempted to handle a number of cases such as when config
doesn't exist, getting a config for specific skill, or getting all skill configurations. This resulted
in the introduction of a bug in PR #50 where the init command attempted to determine if a skill with the
passed in name already existed. The get_skill_config method would make an empty default configuration
if one didn't exist, but seeing a name passed in would then attempt to read from that empty value and
throw an error. This resulted in a new user being unable to initialize a project. To hopefully avoid
other issues in the future the 4 functions previously contained in the get_skill_config method have
been split into their own smaller methods which the commands can make use of as needed.