Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for specifying context values when invoking a skill. #54

Merged
merged 2 commits into from
Feb 2, 2022

Conversation

snow0x2d0
Copy link
Contributor

This adds optional flags for org/user/device ids to the invoke cli command.
Previously we were passing in an empty context however it may be useful, or
even necessary for testing a skill for those ids to be present. If not specified
on the command line a random UUID will be generated.

This adds optional flags for org/user/device ids to the `invoke` cli command.
Previously we were passing in an empty context however it may be useful, or
even necessary for testing a skill for those ids to be present. If not specified
on the command line a random UUID will be generated.
Copy link
Contributor

@angelRev angelRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Previous value of 6 is somewhat too low for CLI commands which may have a large
number of options. While any value is going to be essentially arbitrary 10 seems
as good a place to raise an eyebrow as any.
@snow0x2d0 snow0x2d0 merged commit 90c7bf4 into main Feb 2, 2022
@snow0x2d0 snow0x2d0 deleted the cli-context branch February 2, 2022 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants