Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InputTime takes formatTime for custom i18n time string formatting #237

Merged
merged 3 commits into from
Jul 23, 2020
Merged

InputTime takes formatTime for custom i18n time string formatting #237

merged 3 commits into from
Jul 23, 2020

Conversation

pixelbandito
Copy link
Contributor

No description provided.

@pixelbandito
Copy link
Contributor Author

I did a quick-and-dirty test integration with yalc on the trendkite-front-end app.
Passing (date) => iintl.formatTime(date, { hour: 'numeric', minute: 'numeric', timeZoneName: 'short' }) as the formatTime prop works as expected.

mdespuits
mdespuits approved these changes Jul 15, 2020
View reviewed changes
Copy link
Contributor

@mdespuits mdespuits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍔🌹

@pixelbandito pixelbandito self-assigned this Jul 20, 2020
@pixelbandito pixelbandito force-pushed the input-time-with-custom-format-time branch from 4ed942e to 988886e Compare July 22, 2020 03:50
@pixelbandito pixelbandito force-pushed the input-time-add-step-validation branch from fbf0435 to 74406eb Compare July 23, 2020 18:15
Base automatically changed from input-time-add-step-validation to master July 23, 2020 18:42
@pixelbandito pixelbandito force-pushed the input-time-with-custom-format-time branch from 988886e to 3e107bb Compare July 23, 2020 21:29
@pixelbandito pixelbandito merged commit 845bbee into master Jul 23, 2020
@pixelbandito pixelbandito deleted the input-time-with-custom-format-time branch July 23, 2020 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvmusoke nvmusoke nvmusoke approved these changes

@mdespuits mdespuits mdespuits approved these changes

@dkordik dkordik Awaiting requested review from dkordik

@sebastianvera sebastianvera Awaiting requested review from sebastianvera

@kcj002 kcj002 Awaiting requested review from kcj002

Assignees

@pixelbandito pixelbandito

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pixelbandito @mdespuits @nvmusoke