Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CONTRIBUTING.md and .github/PULL_REQUEST_TEMPLATE.md #174

Merged
merged 4 commits into from
Jan 23, 2019
Merged

Add CONTRIBUTING.md and .github/PULL_REQUEST_TEMPLATE.md #174

merged 4 commits into from
Jan 23, 2019

Conversation

koppor
Copy link
Contributor

@koppor koppor commented Jan 18, 2018

This adds initial contribution guidelines. This refs #173 and should ensure that future updates come with a complete list of translators.

@csl-bot
Copy link
Contributor

csl-bot commented Jan 18, 2018

Awesome! You just created a pull request to the Citation Styles Language locales repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your locale file validates.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your locale file to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot
Copy link
Contributor

csl-bot commented Jan 18, 2018

Yay! Your pull request passed all our automated tests. We'll take a look soon.

@koppor
Copy link
Contributor Author

koppor commented Jan 21, 2018

@adam3smith Does this also look OK for you?

@rmzelle
Copy link
Member

rmzelle commented Jan 21, 2018

I'll rewrite this a little bit before merging, and it might be a few days before I have time to do so, but generally this looks good to me.

@adam3smith
Copy link
Member

Yes, I think we should add to the checklist (formatting and validation at least) but generally I have no objections. @rmzelle feel free to merge when you´re done editing

@adam3smith
Copy link
Member

ping @rmzelle -- I think this would be nice to have

@csl-bot
Copy link
Contributor

csl-bot commented Jan 23, 2019

Yay! Your pull request passed all our automated tests. We'll take a look soon.

@rmzelle rmzelle requested a review from adam3smith January 23, 2019 03:24
@csl-bot
Copy link
Contributor

csl-bot commented Jan 23, 2019

Yay! Your pull request passed all our automated tests. We'll take a look soon.

@rmzelle
Copy link
Member

rmzelle commented Jan 23, 2019

it might be a few days before I have time to do so

a few days

Anyway, @adam3smith, let me know if you like it like this. Also, in the many years since we moved to GitHub, I feel that the GitHub wikis have mostly been replaced by README.md and other repository files for the purpose of providing information to users and contributors. It probably makes sense for us to make README.md the starting point for linking to the various sources of documentation (here and in the other main CSL repos).

@adam3smith
Copy link
Member

Good to merge from my end -- thanks!

@csl-bot
Copy link
Contributor

csl-bot commented Jan 23, 2019

Yay! Your pull request passed all our automated tests. We'll take a look soon.

@rmzelle
Copy link
Member

rmzelle commented Jan 23, 2019

(and do you agree on the wiki sentiment? I think the big advantage of in-repo files is that we get all the benefits of the regular GitHub code workflow, whereas wikis are either locked down or open-to-all)

@rmzelle rmzelle merged commit 6ccf164 into citation-style-language:master Jan 23, 2019
@rmzelle
Copy link
Member

rmzelle commented Jan 23, 2019

Thanks both!

@koppor koppor deleted the add-contributing branch March 7, 2019 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants