Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create journal-of-microscopy.csl #6996

Merged
merged 3 commits into from
Sep 11, 2024

Conversation

POBrien333
Copy link
Contributor

closes #6988

Guidelines not in sync with actual papers.

closes citation-style-language#6988

Guidelines not in sync with actual papers.
Copy link

github-actions bot commented Apr 2, 2024

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

Copy link

github-actions bot commented Apr 2, 2024

😟 There are some issues with your submission.

1 test failed

The CSL Style Repository may not contain any (non-excepted) duplicate ISSNs

expected: {}
     got: {"0006-2960"=>["biochemistry", "journal-of-microscopy"], "1520-4995"=>["biochemistry", "journal-of-microscopy"]}

(compared using ==)

Diff:
@@ -1,2 +1,4 @@
+"0006-2960" => ["biochemistry", "journal-of-microscopy"],
+"1520-4995" => ["biochemistry", "journal-of-microscopy"],

Please check the test report for details.

Copy link

github-actions bot commented Apr 2, 2024

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

journal-of-microscopy.csl (new)
1,2
3,4

1.Hancké, B., Rhodes, M., & Thatcher, M. (Eds.). (2007). Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford University PressOxford and New York.
2.CSL search by example. (2012). Citation Style Editor. http://editor.citationstyles.org/searchByExample/.
3.Mares, I. (2001). Firms and the welfare state: When, why, and how does social policy matter to employers?, in Varieties of capitalism. The institutional foundations of comparative advantage (Hall, P. A., and Soskice, D., Eds.), pp 184–213. Oxford University PressNew York.
4.Fenner, M., Crosas, M., Grethe, J. S., Kennedy, D., Hermjakob, H., Rocca-Serra, P., Durand, G., Berjon, R., Karcher, S., Martone, M., & Clark, T. (2019). A data citation roadmap for scholarly data repositories. Scientific Data, 6, 28.

@bwiernik
Copy link
Member

@POBrien333 Missing a delimiter between publisher and publisher-place

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Aug 27, 2024
@POBrien333
Copy link
Contributor Author

I think that's an error of the generated examples in here.
Works fine and is set:
image

@github-actions github-actions bot removed the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Aug 28, 2024
@adam3smith
Copy link
Member

(reminder that citeproc-ruby handles delimiters that involve groups and conditionals incorrectly. We should try to get that fixed, though Sylvester is unfortunately not developing anymore

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Aug 28, 2024
@bwiernik
Copy link
Member

bwiernik commented Sep 8, 2024

@adam3smith @retorquere Sylvester pushed a fix to citeproc-ruby at RubyGems. Is there anything we need to do to update the repo to the latest version of the Gem?

@retorquere
Copy link
Collaborator

Sheldon still pulls in 2.0. Easy to fix but I'd have to set up Ruby again -- if someone has a working ruby env, changing the gemspec file and running bundle install will get the lockfile updated, then check the lot in -- this repo pulls sheldon from github at every run so there's no separate publishing step.

@bwiernik
Copy link
Member

bwiernik commented Sep 9, 2024

I think I have Ruby set up -- I'll check it out this weekend

@bwiernik bwiernik merged commit 0ac626c into citation-style-language:master Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Requesting style: Journal of Microscopy
4 participants