Fix locator conditions (resolve #142)

[zepinglee]

This patch fixes issue #142.

In the original code, item.locator.label raises VariableError since there is no locator in the CitationItem. This error is then ignored in process_children() called in Layout.render_citation(), which causes empty output.

citeproc-py/citeproc/model.py

Lines 1470 to 1472 in d7fb0a0

	def _locator(self, item):
	return [var.replace('-', ' ') == item.locator.label
	for var in self.get('locator').split()]

citeproc-py/citeproc/model.py

Lines 551 to 556 in d7fb0a0

	try:
	text = child.process(item, **kwargs)
	if text is not None:
	output.append(text)
	except VariableError:
	pass

[yarikoptic]

could a test be added which would catch original bug and now pass?

[zepinglee]

could a test be added which would catch original bug and now pass?

Is there any directory holding similars tests?

I suggest adding a local directory similar to test-suite/processor-tests/humans with tests in the same format (e.g., affix_CommaAfterQuote.txt). This requires modifying tests/citeproc-test.py.

[zepinglee]

@yarikoptic In 8ae7c71, I added a directory for local tests in the format of the test-suite.

In the master branch, the bug is revealed as follows.

$ PYTHONPATH=. py tests/citeproc-test.py condition_LocatorVariables -v
>>> Testing condition_LocatorVariables.txt
EXP: (Doe)
     (Doe 23)
RES: ()
     (Doe 23)
<<< FAILED

My patch fixes the bug.

$  PYTHONPATH=. py tests/citeproc-test.py condition_LocatorVariables -v
>>> Testing condition_LocatorVariables.txt
EXP: (Doe)
     (Doe 23)
RES: (Doe)
     (Doe 23)
<<< SUCCESS

[tmorrell]

Thanks @zepinglee. The change looks great and for adding the local test structure. Apologies for the delay in getting this looked at.

[tmorrell]

@zepinglee Could you rebase this PR so the CI can run? I tried to do it for you but don't seem to have permission.

[yarikoptic]

what meaning did you imply by "local"? should it be may be "resources" or "files"?

in any case -- would also need to tune up MANIFEST.in to include .txt files I guess.

[zepinglee]

what meaning did you imply by "local"? should it be may be "resources" or "files"?

It means local tests in this repository rather than tests from the standard test-suite. It's named following the fixtures/local directory of citeproc-js.

in any case -- would also need to tune up MANIFEST.in to include .txt files I guess.

I've added 7ade76c.

[zepinglee]

@zepinglee Could you rebase this PR so the CI can run? I tried to do it for you but don't seem to have permission.

Done.

[yarikoptic]

it should be included, not pruned per se. tests/citeproc-test seems to be some clone which tests do "behind the curtain". I think you should instead add *.txt into line above

recursive-include tests *.py *.bib *.txt

and please check if it does include those files in source distribution

[zepinglee]

it should be included, not pruned per se. tests/citeproc-test seems to be some clone which tests do "behind the curtain". I think you should instead add *.txt into line above

I've modified in dbbb5de.

and please check if it does include those files in source distribution

Yes, the tests/local/*.txt files are included.