Skip to content
This repository has been archived by the owner on Jan 9, 2021. It is now read-only.

Fix first and last name for api v2 #85

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ipsoftware
Copy link

No description provided.

@AmsTaFFix
Copy link
Contributor

@ipsoftware you code can't pass checks, proper name of method is LastName and FirstName, you can't change names only in one place

@ipsoftware
Copy link
Author

@ipsoftware you code can't pass checks, proper name of method is LastName and FirstName, you can't change names only in one place

If I change the method names, all older user implementations will stop working.

@AmsTaFFix
Copy link
Contributor

@ipsoftware you code can't pass checks, proper name of method is LastName and FirstName, you can't change names only in one place

If I change the method names, all older user implementations will stop working.

yes, and that's why you can not change method names in other parts of code.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants