Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix check failure #7396

Closed
wants to merge 2 commits into from
Closed

fix check failure #7396

wants to merge 2 commits into from

Conversation

cstarc1
Copy link
Contributor

@cstarc1 cstarc1 commented Jan 2, 2024

foreign_key_to_reference_shard_rebalance failed because partition of 2024 year does not exist, fixed by add default partition.

fix check failure , because partition of 2024 year does not exist
@cstarc1
Copy link
Contributor Author

cstarc1 commented Jan 2, 2024

@cstarc1 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree company="HUNDSUN"

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Merging #7396 (99713cd) into main (d940cfa) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 99713cd differs from pull request most recent head 4f1e1ef. Consider uploading reports for the commit 4f1e1ef to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7396      +/-   ##
==========================================
- Coverage   89.61%   89.60%   -0.01%     
==========================================
  Files         278      278              
  Lines       60203    60185      -18     
  Branches     7496     7494       -2     
==========================================
- Hits        53948    53931      -17     
+ Misses       4106     4105       -1     
  Partials     2149     2149              

@JelteF JelteF closed this in #7400 Jan 4, 2024
JelteF pushed a commit that referenced this pull request Jan 4, 2024
foreign_key_to_reference_shard_rebalance failed because partition of
2024 year does not exist, fixed by add default partition.

Replaces #7396 by adding a rule
that allows properly testing foreign_key_to_reference_shard_rebalance
via run_test.py.

Closes #7396

Co-authored-by: chuhx <148182736+cstarc1@users.noreply.github.com>
@JelteF
Copy link
Contributor

JelteF commented Jan 4, 2024

Thanks for providing this fix. I made sure to add you in the final commit as Co-Authored-By (so github lists you as one of the authors)

naisila pushed a commit that referenced this pull request Dec 31, 2024
foreign_key_to_reference_shard_rebalance failed because partition of
2024 year does not exist, fixed by add default partition.

Replaces #7396 by adding a rule
that allows properly testing foreign_key_to_reference_shard_rebalance
via run_test.py.

Closes #7396

Co-authored-by: chuhx <148182736+cstarc1@users.noreply.github.com>
(cherry picked from commit 968ac74)
naisila pushed a commit that referenced this pull request Dec 31, 2024
foreign_key_to_reference_shard_rebalance failed because partition of
2024 year does not exist, fixed by add default partition.

Replaces #7396 by adding a rule
that allows properly testing foreign_key_to_reference_shard_rebalance
via run_test.py.

Closes #7396

Co-authored-by: chuhx <148182736+cstarc1@users.noreply.github.com>
(cherry picked from commit 968ac74)
naisila added a commit that referenced this pull request Dec 31, 2024
foreign_key_to_reference_shard_rebalance failed because partition of
2024 year does not exist, fixed by add default partition.

Replaces #7396 by adding a rule
that allows properly testing foreign_key_to_reference_shard_rebalance
via run_test.py.

Closes #7396

Co-authored-by: chuhx <148182736+cstarc1@users.noreply.github.com>
(cherry picked from commit 968ac74)

Co-authored-by: Onur Tirtir <onurcantirtir@gmail.com>
tejeswarm pushed a commit that referenced this pull request Jan 7, 2025
foreign_key_to_reference_shard_rebalance failed because partition of
2024 year does not exist, fixed by add default partition.

Replaces #7396 by adding a rule
that allows properly testing foreign_key_to_reference_shard_rebalance
via run_test.py.

Closes #7396

Co-authored-by: chuhx <148182736+cstarc1@users.noreply.github.com>
(cherry picked from commit 968ac74)

Co-authored-by: Onur Tirtir <onurcantirtir@gmail.com>
onurctirtir added a commit that referenced this pull request Jan 7, 2025
foreign_key_to_reference_shard_rebalance failed because partition of
2024 year does not exist, fixed by add default partition.

Replaces #7396 by adding a rule
that allows properly testing foreign_key_to_reference_shard_rebalance
via run_test.py.

Closes #7396

Co-authored-by: chuhx <148182736+cstarc1@users.noreply.github.com>
(cherry picked from commit 968ac74)

Co-authored-by: Onur Tirtir <onurcantirtir@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants