Fixing default citus.local_shared_pool_size calculation #7640
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes the default calculation for
citus.local_shared_pool_size
when a value is not set for the GUC.The original approach was to divide
citus.client_max_connections
by 2, which could lead to errors even when there is enough room for new loopback connections.Example:
Assuming
citus.client_max_connections = 80
and the current active client backend count is40
, the following line would create an error if the new loopback connection issuer were not a superuser:https://github.com/citusdata/citus/blob/main/src/backend/distributed/connection/shared_connection_stats.c#L383-L386