Binary input/output for HLL type. Fix compiler warnings. Remove logs from tests. #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hll.c:2269:13: warning: variable ‘vers’ set but not used [-Wunused-but-set-variable] hll.c:2290:13: warning: variable ‘vers’ set but not used [-Wunused-but-set-variable] hll.c:2311:13: warning: variable ‘vers’ set but not used [-Wunused-but-set-variable] hll.c:2332:13: warning: variable ‘vers’ set but not used [-Wunused-but-set-variable] hll.c:2392:13: warning: variable ‘vers’ set but not used [-Wunused-but-set-variable] MurmurHash3.cpp:86:23: warning: always_inline function might not be inlinable [-Wattributes] MurmurHash3.cpp:73:23: warning: always_inline function might not be inlinable [-Wattributes] MurmurHash3.cpp:65:23: warning: always_inline function might not be inlinable [-Wattributes] MurmurHash3.cpp:60:23: warning: always_inline function might not be inlinable [-Wattributes]
|
@alberts Thank you for the PR! I just got back from vacation but am at a conference until Wednesday. I'll be merging this and cutting a release then. |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Binary input/output for HLL type. Helps to make bulk loads faster.
Fix GCC 4.8 compiler warnings.
hll.c:2269:13: warning: variable ‘vers’ set but not used [-Wunused-but-set-variable]
hll.c:2290:13: warning: variable ‘vers’ set but not used [-Wunused-but-set-variable]
hll.c:2311:13: warning: variable ‘vers’ set but not used [-Wunused-but-set-variable]
hll.c:2332:13: warning: variable ‘vers’ set but not used [-Wunused-but-set-variable]
hll.c:2392:13: warning: variable ‘vers’ set but not used [-Wunused-but-set-variable]
MurmurHash3.cpp:86:23: warning: always_inline function might not be inlinable [-Wattributes]
MurmurHash3.cpp:73:23: warning: always_inline function might not be inlinable [-Wattributes]
MurmurHash3.cpp:65:23: warning: always_inline function might not be inlinable [-Wattributes]
MurmurHash3.cpp:60:23: warning: always_inline function might not be inlinable [-Wattributes]
Remove NOTICE logs from tests because they don't seem to be consistent across different versions of Postgres.