Fix out of range

[hidva]

Before fix in multiset_unpack():

After fix:

The hlltest.sql is here

Before fix in check_modifiers():

After fix:

$pg_config 
BINDIR = /home/pg/pgbin/bin
DOCDIR = /home/pg/pgbin/share/doc/postgresql
HTMLDIR = /home/pg/pgbin/share/doc/postgresql
INCLUDEDIR = /home/pg/pgbin/include
PKGINCLUDEDIR = /home/pg/pgbin/include/postgresql
INCLUDEDIR-SERVER = /home/pg/pgbin/include/postgresql/server
LIBDIR = /home/pg/pgbin/lib
PKGLIBDIR = /home/pg/pgbin/lib/postgresql
LOCALEDIR = /home/pg/pgbin/share/locale
MANDIR = /home/pg/pgbin/share/man
SHAREDIR = /home/pg/pgbin/share/postgresql
SYSCONFDIR = /home/pg/pgbin/etc/postgresql
PGXS = /home/pg/pgbin/lib/postgresql/pgxs/src/makefiles/pgxs.mk
CONFIGURE = '--enable-cassert' '--prefix=/home/pg/pgbin' '--enable-debug' 'CFLAGS=-O0 -fsanitize=address' 'LDFLAGS=-fsanitize=address'
CC = gcc
CPPFLAGS = -D_GNU_SOURCE
CFLAGS = -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -g -O0 -fsanitize=address
CFLAGS_SL = -fPIC
LDFLAGS = -fsanitize=address -Wl,--as-needed -Wl,-rpath,'/home/pg/pgbin/lib',--enable-new-dtags
LDFLAGS_EX = 
LDFLAGS_SL = 
LIBS = -lpgcommon -lpgport -lz -lreadline -lrt -lcrypt -ldl -lm 
VERSION = PostgreSQL 9.6.15

[citus-bot]

Hi @hidva, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement.

[hidva]

I cannot receive verify letter from CITUSDATA.

[hidva]

Do not forget 8 bytes occupy by ms_explicit_t::mse_nelem!

So this should be (i_size - hdrsz) > (MS_MAXDATA - sizeof(size_t))!

[hidva]

Fix fail in make installcheck later~

[citus-bot]

You did it @hidva!

Thank you for signing the Citus Data Contributor License Agreement. We can now accept this contribution and all future contributions from you.

Somebody from our team will proceed with code review.

[serprex]

All looks fine. Bit unnerving having regression output be architecture dependent

[serprex]

These functions should have prototypes declared at top of file with other static prototypes

[marcocitus]

seems there are no declarations for most other functions