Add empty search results component #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateoclarke
approved these changes
Dec 29, 2017
| @@ -0,0 +1,22 @@ | |||
| import React, { Component } from 'react'; | |||
| import _ from 'lodash'; | |||
There was a problem hiding this comment.
Did we end up using lodash in this component?
There was a problem hiding this comment.
Looks like we didn't. The import can also be removed from https://github.com/cityofaustin/grackl/pull/122/files#diff-e774cc41ff1bf4a0081b4192d7dcc984R2
There was a problem hiding this comment.
cool! I'll take care of it.
|
Thanks for this PR @jmensch! I'm going to go ahead and merge it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #89
Adds and presents a simple component when project search results return zero.
I think attaching the
Searchcomponent here as well is the way to go, but we're blocked by gatsbyjs/gatsby#2074.