-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Process/Scripts To Update Data in Portal #3
Comments
1+ |
it would be cool to use travisci or something similar to do this. would also be cool if socrata supported it natively as a github postcommit hook. |
@seabre Is this something that I can change due to your latest commit? Also, does the readme file need updated with the build status or is that something to add later? |
@aplannersguide There is a TravisCI badge you can add, but TravisCI needs to be configured, first. |
I have a user on the data portal especially for TravisCI.
You can add me to this repo and I can do it (I have to have access to the repo to generate encrypted credentials) or you can create a user on the data portal for the same purpose and I can show you how to add those credentials. |
@seabre added you as an admin for this repo. Let me know if you need anything else. |
I had to rerun the build a few times for tweaking permissions, but it looks good. |
@jden @aplannersguide I turned off builds for pull requests. Although this could be beneficial, I'm doing some custom stuff for deployment in Any workarounds you all could think of would be awesome. |
I usually have my build script do different things depending on whether it's a pull request, eg test for a pull request, test + deploy for a merge / push. This what, you get the benefit of Travis giving feedback on whether the PR is going to be okay to merge. |
Right, but I'm thinking of the case that a user either unknowingly/maliciously modifies As is now, if I had Travis building PRs, a user could send a PR that modifies the after_success hook to modify other datasets owned by the deployment user. |
But yeah, I agree. The feedback from Travis is really really valuable. I could strip-out the automated deployment and do automated updates another way. I'd like to keep both though, since it's a really really nice workflow. |
@aplannersguide Yes. If the test fails, the updated data will not deploy to the data portal. If the test passes, it will deploy. Both of these scenarios is what we want to happen, but we also want to test pull requests to help see if they are good for merging. Due to the issue I noted though, I've turned testing pull requests off. I want to turn this back on, but a workaround for the issue needs to be found. I might try out CircleCI and see if I can use them in a way that can work around it. |
Whenever changes are made to
bicycle_parking.geojson
, a process/scripts should be in place so that the data on the portal is updated.The text was updated successfully, but these errors were encountered: