Use settingsFactory intead of settings for angular modules.

We are moving toward the use of settingsFactory and away from settings for angular modules.
This would allow the list of modules to be cached as it would only contain static metadata.

CRM/Core/Page/AJAX/Attachment.php

@@ -130,6 +130,15 @@ public static function sendResponse($result) {
     CRM_Utils_JSON::output(array_merge($result));
   }
 
+  /**
+   * @return array
+   */
+  public static function angularSettings() {
+    return [
+      'token' => self::createToken(),
+    ];
+  }
+
   /**
    * @return string
    */

ang/crmAttachment.ang.php

@@ -5,8 +5,6 @@
   'js' => ['ang/crmAttachment.js'],
   'css' => ['ang/crmAttachment.css'],
   'partials' => ['ang/crmAttachment'],
-  'settings' => [
-    'token' => \CRM_Core_Page_AJAX_Attachment::createToken(),
-  ],
+  'settingsFactory' => ['CRM_Core_Page_AJAX_Attachment', 'angularSettings'],
   'requires' => ['angularFileUpload', 'crmResource'],
 ];

ang/crmStatusPage.ang.php

@@ -7,6 +7,5 @@
   'js' => ['ang/crmStatusPage.js', 'ang/crmStatusPage/*.js'],
   'css' => ['ang/crmStatusPage.css'],
   'partials' => ['ang/crmStatusPage'],
-  'settings' => [],
   'requires' => ['crmUi', 'crmUtil', 'ngRoute', 'crmResource'],
 ];

ang/exportui.ang.php

@@ -19,5 +19,4 @@
     'ui.sortable',
     'dialogService',
   ],
-  'settings' => [],
 ];

tests/phpunit/Civi/Angular/ManagerTest.php

@@ -48,6 +48,7 @@ public function testGetModules() {
       'css' => 0,
       'partials' => 0,
       'settings' => 0,
+      'settingsFactory' => 0,
     ];
 
     foreach ($modules as $module) {
@@ -80,12 +81,17 @@ public function testGetModules() {
           $counts['settings']++;
         }
       }
+      if (isset($module['settingsFactory'])) {
+        $this->assertTrue(is_callable($module['settingsFactory']));
+        $counts['settingsFactory']++;
+      }
     }
 
     $this->assertTrue($counts['js'] > 0, 'Expect to find at least one JS file');
     $this->assertTrue($counts['css'] > 0, 'Expect to find at least one CSS file');
     $this->assertTrue($counts['partials'] > 0, 'Expect to find at least one partial HTML file');
-    $this->assertTrue($counts['settings'] > 0, 'Expect to find at least one setting');
+    $this->assertTrue($counts['settingsFactory'] > 0, 'Expect to find at least one settingsFactory');
+    $this->assertEquals(0, $counts['settings'], 'Angular settings are deprecated in favor of settingsFactory');
   }
 
   /**