CRM-11926 Improve error message on APi failure to include DB error message #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, don't pull it, on IRC with kurund, we are NOT going to do it from this master but from a branch |
ravishnair
pushed a commit
to ravishnair/civicrm-core
that referenced
this pull request
Jun 14, 2013
---------------------------------------- * CRM-12809: Reserved CustomGroups http://issues.civicrm.org/jira/browse/CRM-12809
Merged
totten
referenced
this pull request
in totten/civicrm-core
Jul 30, 2013
When defining multiple cases in CRM_Report_Form_Contribute_Detail, the second case fails due to an uninitialized (lost?) global. api_v3_UFFieldTest seems to have a work-around. ``` 1) CRM_Report_Form_Contribute_DetailTest::testReportOutput with data set #1 ('CRM_Report_Form_Contribute_Detail', array(array('first_name', 'email', 'total_amount'), array('gte', 50)), 'fixtures/dataset.sql', 'fixtures/report.csv') Undefined index: _HTML_QuickForm_registered_rules /Applications/MAMP/htdocs/sites/all/modules/civicrm/packages/HTML/QuickForm/RuleRegistry.php:122 /Applications/MAMP/htdocs/sites/all/modules/civicrm/packages/HTML/QuickForm/RuleRegistry.php:98 /Applications/MAMP/htdocs/sites/all/modules/civicrm/packages/HTML/QuickForm.php:389 /Applications/MAMP/htdocs/sites/all/modules/civicrm/CRM/Core/Form.php:187 /Applications/MAMP/htdocs/sites/all/modules/civicrm/CRM/Core/Form.php:156 /Applications/MAMP/htdocs/sites/all/modules/civicrm/CRM/Report/Form.php:256 /Applications/MAMP/htdocs/sites/all/modules/civicrm/CRM/Report/Form/Contribute/Detail.php:362 /Applications/MAMP/htdocs/sites/all/modules/civicrm/CRM/Core/Controller.php:426 /Applications/MAMP/htdocs/sites/all/modules/civicrm/CRM/Core/Controller/Simple.php:79 /Applications/MAMP/htdocs/sites/all/modules/civicrm/tests/phpunit/CiviTest/CiviReportTestCase.php:43 /Applications/MAMP/htdocs/sites/all/modules/civicrm/tests/phpunit/CRM/Report/Form/Contribute/DetailTest.php:105 /Applications/MAMP/htdocs/sites/all/modules/civicrm/tools/scripts/phpunit:75 ``` ---------------------------------------- * CRM-12622: Create framework for example report data files http://issues.civicrm.org/jira/browse/CRM-12622
kurund
added a commit
to kurund/civicrm-core
that referenced
this pull request
Jan 6, 2014
---------------------------------------- * CRM-14052: Tagset fixes http://issues.civicrm.org/jira/browse/CRM-14052
Edzelopez
referenced
this pull request
in Edzelopez/civicrm-core
Feb 6, 2014
MISC-32 Added support for contribution_id to lineitem table
rohankatkar
pushed a commit
to rohankatkar/civicrm-core-master
that referenced
this pull request
Mar 19, 2014
VAT-88 Added sales account option value on install + upgrade. Also handl...
rohankatkar
pushed a commit
to rohankatkar/civicrm-core-master
that referenced
this pull request
May 22, 2014
VAT-88 Associate the tax to be charged to the financial type + Add new c...
yashodha
pushed a commit
to yashodha/civicrm-core
that referenced
this pull request
Sep 30, 2014
kurund
added a commit
to kurund/civicrm-core
that referenced
this pull request
Dec 9, 2014
batch entry for pledges
colemanw
referenced
this pull request
in colemanw/civicrm-core
Jan 13, 2015
MegaphoneJon
referenced
this pull request
in MegaphoneJon/civicrm-core
Apr 26, 2015
CRM-13823: combine status messages into a single notification
kurund
pushed a commit
to kurund/civicrm-core
that referenced
this pull request
May 12, 2015
Default created date to current timestamp; hopefully merged from Eileen's PR#1
davecivicrm
pushed a commit
that referenced
this pull request
Jul 21, 2015
Fixed spelling of 'Memebership' in 219 and 394
Closed
This was referenced Sep 18, 2023
This was referenced Jan 4, 2024
Closed
mattwire
pushed a commit
that referenced
this pull request
Mar 4, 2024
Gives inline accordion the light utility class
eileenmcnaughton
pushed a commit
that referenced
this pull request
Apr 18, 2024
After running regen, toward the end of the process, there are some warnings like: ``` Generating Membership Generating MembershipPayment Generating MembershipLog Deprecated: strtr(): Passing null to parameter #1 ($string) of type string is deprecated in /home/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/CodeGen/GenerateData.php on line 1563 Call Stack: 0.0035 423192 1. {main}() /home/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/sql/GenerateData.php:0 1.0962 56966984 2. CRM_Core_CodeGen_GenerateData->generateAll() /home/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/sql/GenerateData.php:86 2.6564 102240512 3. CRM_Core_CodeGen_GenerateData->generate($itemName = 'MembershipLog') /home/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/CodeGen/GenerateData.php:84 2.6564 102240560 4. CRM_Core_CodeGen_GenerateData->addMembershipLog() /home/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/CodeGen/GenerateData.php:113 2.6592 102261720 5. CRM_Core_CodeGen_GenerateData::repairDate($date = NULL) /home/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/CodeGen/GenerateData.php:1580 30.7495 102266384 6. strtr($string = NULL, $from = ['-' => '', ':' => '', ' ' => '']) /home/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/CodeGen/GenerateData.php:1563 Deprecated: strtr(): Passing null to parameter #1 ($string) of type string is deprecated in /home/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/CodeGen/GenerateData.php on line 1563 Call Stack: 0.0035 423192 1. {main}() /home/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/sql/GenerateData.php:0 1.0962 56966984 2. CRM_Core_CodeGen_GenerateData->generateAll() /home/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/sql/GenerateData.php:86 2.6564 102240512 3. CRM_Core_CodeGen_GenerateData->generate($itemName = 'MembershipLog') /home/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/CodeGen/GenerateData.php:84 2.6564 102240560 4. CRM_Core_CodeGen_GenerateData->addMembershipLog() /home/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/CodeGen/GenerateData.php:113 30.7583 102263704 5. CRM_Core_CodeGen_GenerateData::repairDate($date = NULL) /home/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/CodeGen/GenerateData.php:1580 30.7583 102263704 6. strtr($string = NULL, $from = ['-' => '', ':' => '', ' ' => '']) /home/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/CodeGen/GenerateData.php:1563 Generating PCP Generating SoftContribution Generating Pledge Generating PledgePayment ```
This was referenced Jun 18, 2024
seamuslee001
pushed a commit
that referenced
this pull request
Aug 29, 2024
Before
------
If you run this test on Standalone, it fails: like so
```
CRM_Activity_BAO_ActivityTest::testSendEmailWillReplaceTokensUniquelyForEachContact3
Exception: CRM_Core_Exception: "rename(/home/homer/buildkit/build/build-1/web/public/custom/test_email_create.txt,
/home/homer/buildkit/build/build-1/web/private/attachment//test_email_create.txt): No such file or directory"
#0 /home/homer/buildkit/build/build-1/web/core/CRM/Contact/Form/Task/EmailTrait.php(867): civicrm_api3("Activity", "create", (Array:9))
#1 /home/homer/buildkit/build/build-1/web/core/CRM/Contact/Form/Task/EmailTrait.php(788): CRM_Contact_Form_Task_Email->createEmailActivity(6, "subject:Mr. Joe Red II", "html:Mr. Joe Red II", "text:Mr. Joe Red II {$contact.first_name}", "", 1, (Array:1), NULL)
...
After
-----
Passes
Comments
--------
I believe this makes standalone behave the same way as Drupal.
However, the underlying scenario is a bit weird -- it seems that `rename()`
puts the file into the same place where it already is. Which is weird.
If the purpose is to create an example file and put it through the same paces as
day-to-day workflows, then you'd probably need to put the sample file somewhere
else (like sys_get_temp_dir()).
totten
pushed a commit
that referenced
this pull request
Sep 5, 2024
CRM_Event_Page_EventInfoTest::testFullMessage
Exception: CRM_Extension_Exception_MissingException: "Failed to find extension: civi_mail"
#0 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Extension/Container/Basic.php(143): CRM_Extension_Container_Basic->getRelPath("civi_mail")
#1 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Extension/Mapper.php(233): CRM_Extension_Container_Basic->getPath("civi_mail")
#2 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Core/Resources.php(261): CRM_Extension_Mapper->keyToBasePath("civi_mail")
#3 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Core/Resources.php(311): CRM_Core_Resources->getPath("civi_mail")
#4 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/Civi/Angular/Manager.php(208): CRM_Core_Resources->glob("civi_mail", (Array:3))
#5 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/Civi/Angular/Manager.php(114): Civi\Angular\Manager->resolvePatterns((Array:59))
#6 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Utils/Check/Component/Env.php(1178): Civi\Angular\Manager->getModules()
#7 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Utils/Check/Component.php(76): CRM_Utils_Check_Component_Env->checkAngularModuleSettings(FALSE)
#8 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Utils/Check.php(215): CRM_Utils_Check_Component->checkAll((Array:0), FALSE)
#9 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Utils/Check.php(185): CRM_Utils_Check::checkStatus()
#10 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Utils/Check.php(93): CRM_Utils_Check::checkAll()
#11 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Core/Page.php(267): CRM_Utils_Check->showPeriodicAlerts()
#12 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Event/Page/EventInfo.php(325): CRM_Core_Page->run()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this the right way?