-
-
Notifications
You must be signed in to change notification settings - Fork 812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRM-20351 Multiple pages repeat stuff in the page run() method, invoking hooks multiple times #10068
Conversation
Test failures are unrelated, as best as I can tell. I'm getting the |
test this please |
@agh1 are you able to rebase this? |
@seamuslee yeah not a prob. #10278 was opened and merged all in the course of the day and broke this--go figure. |
Sorry @agh1 I didn't see this one before merging he other. |
@agh1 @eileenmcnaughton |
@agh1 @colemanw @eileenmcnaughton I have squashed multiple commits and fixed related test failures. Also reviewed the patch and its working fine. Since the changes here are vital to basic page, so I need if someone can eyeball the patch to ensure that the fix won't cause any uninteded regression, before merge. |
@civicrm-builder retest this please |
Jenkins test this please |
@colemanw I have fixed the related test build failures. |
https://issues.civicrm.org/jira/browse/CRM-20351