Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRM-20607 - Dedupe - Allow saving reserved groups #10383

Merged
merged 1 commit into from
Jul 29, 2017
Merged

CRM-20607 - Dedupe - Allow saving reserved groups #10383

merged 1 commit into from
Jul 29, 2017

Conversation

MegaphoneJon
Copy link
Contributor

@MegaphoneJon MegaphoneJon commented May 19, 2017 •
edited by civicrm-builder
Loading

jcorlew
jcorlew approved these changes Jul 27, 2017
View reviewed changes
Copy link

@jcorlew jcorlew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed original problem of not being able to reassign a reserved rule to unsupervised
Applied this patch successfully
Confirmed I could change a reserved rule to unsupervised
Also confirmed that a rule with a threshold of 0 could not be created.

@agh1
Copy link
Contributor

agh1 commented Jul 27, 2017

@hhank5ak @jcorlew and I looked at this together and it's good to merge. @totten @colemanw

@colemanw colemanw merged commit ddcf8c7 into civicrm:master Jul 29, 2017
@MegaphoneJon MegaphoneJon deleted the unsupervised-reserved-threshold branch October 10, 2017 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcorlew jcorlew jcorlew approved these changes

Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MegaphoneJon @agh1 @jcorlew @colemanw @civicrm-builder