Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-20648, fixed validation to allow participant to register if their… #10430

Merged
merged 2 commits into from
Jul 20, 2017

Conversation

pradpnayak
Copy link
Contributor

… previous registration is cancelled


@colemanw
Copy link
Member

I don't think this is right. Here is the full list of statuses in core which are not "counted":

  • No-show
  • Cancelled
  • Pending (incomplete transaction)
  • On waitlist
  • Rejected
  • Expired
  • Pending in cart
  • Transferred

I don't think it's appropriate to allow e.g. Rejected participants to register again.
I suggest this PR only targets the one "Cancelled" status and not the others.

@JoeMurray

@totten totten added the master label Jun 27, 2017
@JoeMurray
Copy link
Contributor

I agree with @colemanw and at most would consider reviewing the clarity of the messages provided in the other context. In particular, Pending incomplete might want to provide front end users with indication that the payment has not yet been received by payment processor, and in backend suggest that if the expected payment turn-around for the processor has elapsed, that they check with the payment processor to see if the payment has been received there and if not, contact user about arranging another payment.

@Edzelopez
Copy link
Contributor

@pradpnayak or @monishdeb can you please QA recent changes?

… previous registration is cancelled

----------------------------------------
* CRM-20648: Allow registration in event with cancelled registration
  https://issues.civicrm.org/jira/browse/CRM-20648
----------------------------------------
* CRM-20648: Allow registration in event with cancelled registration
  https://issues.civicrm.org/jira/browse/CRM-20648
@monishdeb
Copy link
Member

Working fine, as expected. @colemanw can you please test this PR?

@pradpnayak
Copy link
Contributor Author

Works fine. Can register participant if status is canceled.

@colemanw colemanw merged commit 0bfced7 into civicrm:master Jul 20, 2017
@monishdeb monishdeb deleted the IIDA-144 branch July 20, 2017 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants