Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIVICRM-152 For a repeating Event series. If change the Price Set for… #10592

Closed
wants to merge 1 commit into from
Closed

CIVICRM-152 For a repeating Event series. If change the Price Set for… #10592

wants to merge 1 commit into from

Conversation

javiya-rupal
Copy link
Contributor

@javiya-rupal javiya-rupal commented Jul 2, 2017

CIVICRM-152 For a repeating Event series. If change the Price Set for a paid Event then this Price Set selection is not applied to all Events in the series even when apply to Every Event is selected

  • Added Code for apply same priceset for paid series events

Issue URL : https://issues.civicrm.org/jira/browse/CRM-20787

… a paid Event then this Price Set selection is not applied to all Events in the series even when apply to Every Event is selected - Added Code for apply same priceset for paid series events
@civicrm-builder
Copy link

Can one of the admins verify this patch?

@agileware
Copy link
Contributor

@javiyarupal thanks very much for the PR. Will review in the next few days.

@seamuslee001
Copy link
Contributor

Jenkins ok to test

@eileenmcnaughton
Copy link
Contributor

@agileware are you still planning on reviewing this?

@agilewarealok
Copy link
Contributor

agilewarealok commented Oct 18, 2017

@eileenmcnaughton
There is an issue with fix from this PR.
It updates (https://github.com/civicrm/civicrm-core/pull/10592/files#diff-bf81190cf90964626ddc54fee5293bc4R54) the price_set_id to the old price_set_id of the parent event. So there is still mismatch between parent and child events.

We've a fix for this and planning to write UT for the same, will create new PR extending this one soon.

@eileenmcnaughton
Copy link
Contributor

Closing this as #11161 has now been merged - which addresses the same issue but builds on this further, addressing the additional comment by @agilewarealok (and adding a unit test!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants