Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove broken symlink from vendor/pear/net_smtp #10676

Merged
merged 1 commit into from
Jul 21, 2017
Merged

Remove broken symlink from vendor/pear/net_smtp #10676

merged 1 commit into from
Jul 21, 2017

Conversation

xurizaemon
Copy link
Member

@xurizaemon xurizaemon commented Jul 16, 2017 •
edited by civicrm-builder
Loading

seamuslee001
seamuslee001 approved these changes Jul 16, 2017
View reviewed changes
Copy link
Contributor

@seamuslee001 seamuslee001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with this patch @totten

@jackrabbithanna
Copy link
Contributor

@seamuslee001 , will this need to be done in 4.6 too?

@seamuslee001
Copy link
Contributor

@jackrabbithanna yes but should be straight forward to grab Chris' commit

seamuslee001
seamuslee001 approved these changes Jul 17, 2017
View reviewed changes
Copy link
Contributor

@seamuslee001 seamuslee001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this and it works

@seamuslee001 seamuslee001 mentioned this pull request Jul 17, 2017
Merged
@eileenmcnaughton eileenmcnaughton merged commit 66ff7bd into civicrm:master Jul 21, 2017
@eileenmcnaughton eileenmcnaughton deleted the CRM-20884-remove_net_smtp_readme_symlink branch July 21, 2017 09:01
@eileenmcnaughton
Copy link
Contributor

merged based on @seamuslee001 QA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seamuslee001 seamuslee001 seamuslee001 approved these changes

Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xurizaemon @jackrabbithanna @seamuslee001 @eileenmcnaughton @civicrm-builder