CRM-20910: Check permission param while retrieving participants from api #10698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jitendrapurohit
force-pushed
the
CRM-20910
branch
from
baa3dc8
to
9ae90c5
Compare
jitendrapurohit
force-pushed
the
CRM-20910
branch
from
9ae90c5
to
450fcdd
Compare
|
jenkins, retest this please |
|
Jenkins test this please |
colemanw
requested changes
Jul 19, 2017
CRM/Event/BAO/Query.php
Outdated
| $checkPermission = TRUE; | ||
| if (!empty($query->_skipPermission)) { | ||
| $checkPermission = FALSE; | ||
| } |
There was a problem hiding this comment.
This could be written in 1 line:
$checkPermission = empty($query->_skipPermission);
|
How do I change the status of this PR as I've updated the changes that were requested. |
colemanw
approved these changes
Jul 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit test added.