CRM-20946, use line total of line item to store in financial item table

[pradpnayak]

---

• CRM-20946: Wrong entries in financial table when contribution is cancelled
  https://issues.civicrm.org/jira/browse/CRM-20946

[Edzelopez]

Tested patch for the following scenario:

1. Added membership with priceset of options $10 and $20.
2. Set contribution status to pending before saving membership.
3. Cancelled contribution.

Amounts were not proportionally assigned to entries in entity trxn table.

After patch:
Reversal entries are proportionally assigned.

[pradpnayak]

@colemanw / @eileenmcnaughton can you please review?

[eileenmcnaughton]

I feel like we have been adding a lot of unit testing covering that function, and the fact this continues to pass unit tests gives me a lot of confidence ... you know where this is going don't you..... if you add a unit test I think this is OK to merge.

[monishdeb]

@eileenmcnaughton I have added unit test 338a3c3

[eileenmcnaughton]

Looks like editing the xml dataset had some flow on effects...

[monishdeb]

@eileenmcnaughton yup forgot to cleanup those newly added contacts in xml. It's fixed now and tests build passes.

[eileenmcnaughton]

OK - this looks good to me - the change is the variable passed when deciding if it is a negative or positive transaction and the unit test gives me confidence that this part won't regress again when we do further tweaking