CRM-20954 Fixing localized financial status problems #10747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monishdeb
reviewed
Jul 24, 2017
CRM/Contribute/BAO/Contribution.php
Outdated
| @@ -3961,7 +3960,7 @@ public static function recordAdditionalPayment($contributionId, $trxnsData, $pay | |||
| $contributionDetails = CRM_Core_DAO::setFieldValue('CRM_Contribute_BAO_Contribution', $contributionId, 'contribution_status_id', $statusId); | |||
| } | |||
| // add financial item entry | |||
| $financialItemStatus = CRM_Core_PseudoConstant::get('CRM_Financial_DAO_FinancialItem', 'status_id'); | |||
| $paidStatus = CRM_Core_PseudoConstant::getKey('CRM_Financial_DAO_FinancialItem', 'status_id', 'Paid'); | |||
There was a problem hiding this comment.
@samuelsov can you initialise this $paidStatus outside the IF-ELSEIF loop, that could avoid the repeated assignment.
There was a problem hiding this comment.
@monishdeb sure, it's done
|
Working as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite trivial patch that uses CRM_Core_PseudoConstant::getKey (localization independent) instead of CRM_Core_PseudoConstant::get (which return a localized version by default)
To reproduce the problem :