CRM-20970 - avoid MySQL error caused by long numeric postal codes

[mfb]

• CRM-20970: long postal code in db prevents searching by zipcode range

[eileenmcnaughton]

I tried to replicate this, but couldn't. In my tests (via the test suite) I found another error in that line of code - if you search for postal code less than 5000 it includes contacts with no postal_code. If you are interested in testing & reviewing that change I will put up a PR.

I am going to merge this despite not being able to replicate the error. It seems that my mysql config is different, but I agree with the logic of not treating numbers longer than 10 characters as postal_codes and I agree that this patch does this.

I also noticed that this casting takes place regardless of the operator in use - there would be some performance cost to that in a '=' operation, perhaps not much.

[mfb]

our production db server has STRICT_TRANS_TABLES - so my guess is that may be required to reproduce? casting an out of bounds integer is only a warning, but that changes to error when doing an insert with STRICT_TRANS_TABLES

I see that civicrm codebase has SET SESSION sql_mode = STRICT_TRANS_TABLES only if isDevelopment() which is identified by .svn or .git directory in the civicrm directory.

[mfb]

the error happens in CRM/Contact/BAO/GroupContactCache.php when creating temporary table 'civicrm_temp_group_contact_cache' . rand(0, 2000)

[xurizaemon]

if isDevelopment() which is identified by .svn or .git directory in the civicrm directory.

I had never come across this! Behavior changes based on details of the hosting environment, wow