CRM-20989 Fix Active provider count to know about multisite #10792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems good - any test cover on this fn? |
|
None previously and none added in with this PR, I'm not sure how to mock up say a 2nd domain in the unit tests |
|
Actually there IS a second domain in the test Db- but on this I'd be happy with a test that just called the function & demonstrated no sql error |
|
@eileenmcnaughton added a unit test and got it to Mock correctly |
|
Damn you are quick! |
|
Merging as per tag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
At Present CRM_SMS_BAO_Provider::getActiveProviders just checks to see if there is an active provider in the database and not if it is in available for the current domain
Before
This can cause scheduled reminders to ask the user to select an SMS provider even when none load due to access issues
After
Correctly only adds in SMS requirements to scheduled providers if there are providers available in the db for the domain
Technical Details
Swaps out max for count to get an accurate count and adds check on the domain_id column
ping @eileenmcnaughton