Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-20610: 'Payment Edit' form improvements #10806

Merged
merged 2 commits into from
Aug 2, 2017

Conversation

monishdeb
Copy link
Member

@monishdeb monishdeb commented Aug 2, 2017

Overview

The Payment Edit form improvements:

  1. Modified payment fields like credit-card-type, pan_truncation and check_number as optional fields.
  2. Added medium-popup to payment-edit action link to minimize the payment edit form size. But there's a limitation - if you open a popup form inside a popup form, that special class has no effect on the form size. Please check the screencast here.
  3. Shifted the action link from left to right.
  4. Added payment_instrument_id and trxn_id fields in payment edit form
  5. Added formRule validation and added rule for pan_truncation to be numeric
  6. Changed the credit_card_type icon field to card_type_id select field.
  7. Used addField to render some FinancialTrxn fields.

Screencast

test-case-5


@monishdeb
Copy link
Member Author

monishdeb commented Aug 2, 2017

@JoeMurray @eileenmcnaughton I have moved few changes from #10776 into this PR along with other improvements mentioned in the PR description.

@colemanw
Copy link
Member

colemanw commented Aug 2, 2017

Looks good.

@colemanw colemanw merged commit 10a1f94 into civicrm:master Aug 2, 2017
@monishdeb monishdeb deleted the CRM-20610-2 branch August 3, 2017 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants