Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRM-21029 - Report - Fix Activity Report SQL Syntax Error #10820

Merged
merged 1 commit into from
Aug 4, 2017
Merged

CRM-21029 - Report - Fix Activity Report SQL Syntax Error #10820

merged 1 commit into from
Aug 4, 2017

Conversation

monishdeb
Copy link
Member

@monishdeb monishdeb commented Aug 4, 2017 •
edited by civicrm-builder
Loading

@totten
Copy link
Member

totten commented Aug 4, 2017

I'm soft +1 for 4.7.24-rc since (a) it seems the regression was very recent (4.7.23) and (b) we're still early in the 4.7.24 RC period and (c) you seem to have comprehension of both the original PR and the follow-up PR.

We do have higher bar for RC updates -- some quick 👍 or 👎 from @colemanw, @eileenmcnaughton, or @seamuslee001 would be reassuring.

@colemanw
Copy link
Member

colemanw commented Aug 4, 2017

👍 for fixing regressions ASAP

@eileenmcnaughton
Copy link
Contributor

I think recent regressions firmly includes the last couple of releases

@colemanw colemanw merged commit 4772195 into civicrm:4.7.24-rc Aug 4, 2017
@seamuslee001
Copy link
Contributor

Just commenting i would have been a +1

@monishdeb monishdeb deleted the CRM-21029 branch August 5, 2017 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
4.7.24-rc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@monishdeb @totten @colemanw @eileenmcnaughton @seamuslee001 @civicrm-builder @tschuettler