Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-21070 Remove reference to outdated template url file #10880

Merged
merged 1 commit into from
Aug 21, 2017

Conversation

seamuslee001
Copy link
Contributor

@seamuslee001 seamuslee001 commented Aug 21, 2017

Overview

In wordpress it would appear that this line causes it to try and load the template file that has now been removed. This was a change introduced in 4.7.24

ping @monishdeb @eileenmcnaughton


@monishdeb
Copy link
Member

works for me :)

@eileenmcnaughton
Copy link
Contributor

@seamuslee001 @monishdeb I see you discussed on chat - do either of you know why this is only affecting wordpress & what PR caused this (so I can understand the original code not so I can mercilessly shame whoever made the mistake :-))

@seamuslee001
Copy link
Contributor Author

A) can't work out why only affecting Wordpress B) file was removed by PR to port AUG changes refactoring how the recepients box opporates

@seamuslee001
Copy link
Contributor Author

@eileenmcnaughton
Copy link
Contributor

Ah OK -it does seem pretty compelling that that file was in fact removed

https://github.com/civicrm/civicrm-core/pull/10303/files#diff-d0c982c144eab42f5fff1593c922b42aL1

@eileenmcnaughton
Copy link
Contributor

I'm going to merge based on the fact the file really does not exist, @monishdeb has tested this & @seamuslee001 is familiar with the patch that introduced the error

@eileenmcnaughton eileenmcnaughton merged commit 8e3a6eb into civicrm:4.7.24-rc Aug 21, 2017
@eileenmcnaughton eileenmcnaughton deleted the CRM-21070 branch August 21, 2017 08:11
@kcristiano
Copy link
Member

@eileenmcnaughton I applied this patch manually to the latest RC (Aug 21st). The recipient box works on WP now.

@eileenmcnaughton
Copy link
Contributor

thanks for confirming @kcristiano

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants