CRM-21135 - Activity filter preference are not remembered when enable…

[jitendrapurohit]

…d in display preference

Overview

RC fix for #10930.

Before

Reload of a page removes the filter setting saved in the database.

After

works fine.

Technical Details

This seem to be due to the difference in form fields which is activity_type_filter_id and activity_type_exclude_filter_id and the setting saved in db does not include filter text in it - activity_type_id and activity_type_exclude_id respectively.

Either this need to handled by:

• changing the form id of this field to be the same as of db setting key OR
• replace db id with the form id as done in this PR(used to be the same in previous versions).

Comments

unit test added.

---

• CRM-21135: Activity filter preference are not remembered when enabled in display preference

[eileenmcnaughton]

@monishdeb @jitendrapurohit - per #10930 if you feel good about this I endorse it going into the rc