CRM-21265: update payment status to Failed if membership transaction… #11072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested and agree with the fix. @eileenmcnaughton can I merge this PR? NOTE: there is a reason we need two exceptions here to |
monishdeb
changed the title
|
this makes sense - happy to merge on @monishdeb testing |
sluc23
pushed a commit
to ixiam/civicrm-core
that referenced
this pull request
Jan 10, 2018
CRM-21265: update payment status to Failed if membership transaction…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update payment status to Failed if membership transaction is declined
Overview
Online page configured for Membership signup with payment processor.
If transaction get declined due to any reason. payment record status should change to 'Failed' from 'Pending' (incomplete transaction).
Before
when transaction declined, exception thrown but not way to update payment status.
After
added additional catch block which update payment status to 'Failed'