-
-
Notifications
You must be signed in to change notification settings - Fork 817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRM-21349: Increase timeout of status message after batch merge #11195
Conversation
CRM/Contact/Page/DedupeFind.php
Outdated
@@ -149,7 +149,7 @@ public function run() { | |||
|
|||
$stats = CRM_Dedupe_Merger::getMergeStatsMsg($cacheKeyString); | |||
if ($stats) { | |||
CRM_Core_Session::setStatus($stats); | |||
CRM_Core_Session::setStatus($stats, '', 'alert', array('expires' => 0)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about giving it a title as well, like "Batch Complete". Also, is this a success message?
@jitendrapurohit did you see my question? |
@colemanw Yes, I think I missed the notification. The title is being updated. For the type - this also includes a message when the contacts were skipped during the merge process, due to which I added Agree, this looks weird when all the contacts were successful in the merge. So thinking of updating the code to do something like -
looks good? |
That would only work in English. But I'm noticing the |
Thx for the update. I'll test this during the weekend. |
Just noticed, the |
CRM-21349: Increase timeout of status message after batch merge
Overview
Increase timeout of status message after batch merge process
Before
Batch merge process usually takes a longer time to complete and displays the status message on completion but it drops off the screen which is no of help as most likely the user won't be watching the screen every second to see when it ends.
After
timeout increased. User can see the message after merge process is complete.