CRM-20343: Override membership status when contribution is cancelled #11198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code looks good to me. @lcdservices can you confirm this is a good change? |
|
@jitendrapurohit @colemanw confirmed -- this works as expected.
|
sluc23
pushed a commit
to ixiam/civicrm-core
that referenced
this pull request
Jan 10, 2018
CRM-20343: Override membership status when contribution is cancelled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Set
is_overrideto true when membership contribution is updated to cancelled.Before
see https://issues.civicrm.org/jira/browse/CRM-20343?focusedCommentId=109217&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-109217
After
is_overrideis correctly set when a contribution is updated.