Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-21360: Make 'Open Case' Activity Optional #11204

Merged

Conversation

MiyaNoctem
Copy link
Contributor

Overview

For greater flexibility in cases, we want to make a change to CiviCase so that the first activity “Open Case” is no longer required for the standard timeline. Basically, there are workflows that you may want to create where the concept of “opening the case” is not relevant - e.g. prospecting or onboarding a new staff member. Given that we store the case start date in any case on the case record itself we would like to make it an optional activity.

Before

Currently in the standard case timeline, the first activity "Open Case” is always required, as it cannot be moved, edited or deleted.

After

Removed conditionals that made 'Open Case' activity on standard timeline mandatory on Case Type create and edit views. Also added a label to default Reference value so users can choose '-- Case Start --' as the reference for offsets.

Removed conditionals that made 'Open Case' activity on standard timeline
mandatory on Case Type create and edit views. Also added a label to default
Reference value so users can choose '-- Case Start --' as reference for
offsets.
@mattwire
Copy link
Contributor

@MiyaNoctem My only concern with this is that other code may rely on the the open case activity. @totten @colemanw you've been working on civicase a lot recently - what are your thoughts please?

@colemanw
Copy link
Member

@MiyaNoctem have you tested this out with opening a new case after removing that activity from the timeline? The CiviCRM "New Case" form is actually hard-coded to create that open case activity afaik.

@MiyaNoctem
Copy link
Contributor Author

@colemanw, I did test creating cases and everything worked ok. I tried setting offsets relative to case start and to activities, and all dates were computed as expected. But that's about all tests I've done. We could arrange for more thorough tests, though. @guanhuan?

This is a screenshot of a case created with a timeline without an open case activity.

image

@colemanw
Copy link
Member

I've tested. It also works with the new CiviCase UI.

@colemanw colemanw merged commit 84896bd into civicrm:master Nov 10, 2017
@jitendrapurohit
Copy link
Contributor

jitendrapurohit commented Dec 26, 2017

Changes done here does not let user to create a new caseType or edit an existing one. Tested on dmaster - Edit Housing Support OR create a new case type using http://dmaster.demo.civicrm.org/civicrm/a/#/caseType/new. (See CRM-21559)

After filling the req fields, the save button is still disabled and don't let user to save the case type form values.

image

Can't we remove the following line completely?

ng-required="activity.name != ''"

@colemanw
Copy link
Member

@jitendrapurohit I agree that line should not be necessary. If it's causing problems, let's remove it. Since this is a serious regression can you please do a PR against the 4.7.30-rc branch?

@jitendrapurohit
Copy link
Contributor

@colemanw Submitted #11473 for the fix against rc.

sluc23 pushed a commit to ixiam/civicrm-core that referenced this pull request Jan 10, 2018
…case-manageable

CRM-21360: Make 'Open Case' Activity Optional
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants