Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-14343 - Remove limit of downloading only 250 errors during CSV import #11233

Merged
merged 1 commit into from
Nov 15, 2017

Conversation

seancolsen
Copy link
Contributor

@seancolsen seancolsen commented Nov 3, 2017

Before

When you download the CSV errors from your CSV import, you only get 250 error rows even if the import has more than 250 errors.

After

There is no limit to the number of errors you can download.

Comments

See CRM-14343 for more details including

  • straightforward steps to reproduce
  • the results of a performance test suggesting that removing this limit does not adversely affect performance
  • opinions from other people supporting this change

@seamuslee001
Copy link
Contributor

I haven't tested this yet but from a code point of view looks very good, I also agree with the principle of the issue.

@mlutfy
Copy link
Member

mlutfy commented Nov 15, 2017

jenkins, test this please

(I'm lazy and I want a demo site)

@mlutfy
Copy link
Member

mlutfy commented Nov 15, 2017

I tested the following:

  • Import contacts
  • Import contributions
  • Import activities
  • Import event participants
  • Import memberships.

I could not find where to import Pledges and Soft-Credits, but I think it's safe to assume it works.

@mlutfy mlutfy merged commit e2157b3 into civicrm:master Nov 15, 2017
sluc23 pushed a commit to ixiam/civicrm-core that referenced this pull request Jan 10, 2018
…or-limit

CRM-14343 - Remove limit of downloading only 250 errors during CSV import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants