Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-21395 port https://github.com/dompdf/dompdf/pull/1570/files using… #11243

Merged
merged 1 commit into from
Nov 5, 2017

Conversation

seamuslee001
Copy link
Contributor

… patch files to civicrm dompdf to fix no-block-level error found

Overview

Further information can be found on this State Exchange post https://civicrm.stackexchange.com/questions/21139/error-no-block-level-parent-found-not-good

Before

Invoice wasn't produced

After

invoice is now produced

ping @monishdeb @eileenmcnaughton @KarinG @adixon

… patch files to civicrm dompdf to fix no-block-level error found
@KarinG
Copy link
Contributor

KarinG commented Nov 5, 2017

Confirming that this patch fixes the PDF generation (specifically Print Invoice button) -> in 4.7.27

@eileenmcnaughton
Copy link
Contributor

Merging based on Karin's review. Seems safe/limited & this is a backport only

@eileenmcnaughton eileenmcnaughton merged commit d51efd5 into civicrm:master Nov 5, 2017
@eileenmcnaughton eileenmcnaughton deleted the CRM-21395 branch November 5, 2017 22:09
@mattwire
Copy link
Contributor

mattwire commented Nov 6, 2017

@seamuslee001 @eileenmcnaughton Problem with this is that it breaks composer update on every subsequent run as patch returns non-zero if patch is already applied. Can we add something like:
if [[ $? -eq 1 ]]; then exit 0; fi
to the end of the script please?

@seamuslee001
Copy link
Contributor Author

Thanks @mattwire I've got a plan

sluc23 pushed a commit to ixiam/civicrm-core that referenced this pull request Jan 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants