[NFC] Additional test #11266
Merged
[NFC] Additional test #11266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eileenmcnaughton
force-pushed
the
additional-test
branch
4 times, most recently
from
933d4f2
to
3baa971
Compare
This test was supposed to demonstrate a failure but actually it demonstrates something working. Still, good to have an additional test
eileenmcnaughton
force-pushed
the
additional-test
branch
from
3baa971
to
f660d2a
Compare
|
Changes make sense to me and its only really adding a new test in and modifying some of the test setups Loos fine to me ping @monishdeb |
|
(merged based on the review of Seamus) |
sluc23
pushed a commit
to ixiam/civicrm-core
that referenced
this pull request
Jan 10, 2018
[NFC] Additional test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds a unit test
Comments
The changes in the non-test code are purely to prevent e-notices failing the test