CRM-21041: Respect default 'Communication Style' when creating a … #11269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
@civicrm-builder add to whitelist |
colemanw
requested changes
Nov 11, 2017
CRM/Contact/BAO/Contact.php
Outdated
|
|
||
| // CRM-21041: set default 'Communication Style' if unset when creating a contact. | ||
| if (empty($params['communication_style_id'])) { | ||
| $params['communication_style_id'] = array_pop(CRM_Core_OptionGroup::values('communication_style', TRUE, NULL, NULL, 'AND is_default = 1')); |
There was a problem hiding this comment.
in some versions of php this won't work because array_pop() can't be called on a function.
| @@ -306,6 +306,11 @@ public static function &create(&$params, $fixAddress = TRUE, $invokeHooks = TRUE | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| // CRM-21041: set default 'Communication Style' if unset when creating a contact. | |||
| if (empty($params['communication_style_id'])) { | |||
There was a problem hiding this comment.
Should also test for the presence of id in params and skip if updating.
There was a problem hiding this comment.
@colemanw
This whole code block lives inside
if (empty($params['contact_id'])) { } check
So this will only be executed when creating a contact and will be skipped when updating one.
Pls let me know if this is not what you were referring to
Thanks
sluc23
pushed a commit
to ixiam/civicrm-core
that referenced
this pull request
Jan 10, 2018
…ult_communication_style_on_api_contact_create CRM-21041: Respect default 'Communication Style' when creating a …
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...Contact via API
Overview
Respect default 'Communication Style' when creating a Contact through the API
Before
When creating a contact via the API, the default 'Communication Style' is not used and the contact has no value set for Communication Style.
After
Now when a contact is created via the API, the default 'Communication Style' is set for that contact.