CRM-21426: Removed duplicate submit buttons on Cancel/Delete Event Participants

[ghost]

Overview

This PR solves an inconsistency with other confirmation pages which only have one set of buttons instead of two. It removes the buttons at the top of the Cancel Event Participants and Delete Event Participants pages and also changes the title of the submit button from "Continue" to "Cancel Registrations" on the Cancel Event Participants page.

Steps to get to the page:

1. Go to CiviCRM > Events > Find Participants > Search
2. Select a few records
3. From Actions, choose Cancel registration
4. Repeat the above and from Actions choose Delete registration

Screenshots

Before:

After:

Technical Details

• This PR alters the templates/CRM/Event/Form/Task/Cancel.tpl file to remove the HTML for the buttons at the top of the form.

• It also alters the CRM/Event/Form/Task/Cancel.tpl file to change the title of the submit button.

Comments

Please review and merge to the master branch.

---

• CRM-21426: Cancel Event Participants - Duplicate Submit Buttons

[civicrm-builder]

Can one of the admins verify this patch?

[mlutfy]

@mihaelmladenov Thanks for the patch. Can you open a JIRA issue on https://issues.civicrm.org? This is necessary so that the change gets correctly logged in the Release Notes. c.f. https://docs.civicrm.org/dev/en/latest/core/contributing/

[mlutfy]

jenkins, test this please

[ghost]

Hi Mathieu, I just registered at the site and am pending approval. Can you approve it and I will create the JIRA issue after that. Thanks! Best regards, Mihael

…

On 14 November 2017 at 16:19, Mathieu Lu ***@***.***> wrote: jenkins, test this please — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#11277 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/APeN-4SLjHT7RZ2jNHR_oi6_s0S9QNd8ks5s2aFzgaJpZM4QdScr> .

[mlutfy]

@mihaelmladenov done!

[ghost]

@mlutfy Thanks. I've created one:
https://issues.civicrm.org/jira/browse/CRM-21426

[mlutfy]

I tested this patch (on http://core-11277-19jsu.test-ubu1204-5.civicrm.org).

@mihaelmladenov Could you also fix the "Delete Participants" action?

[ghost]

@mlutfy This is now done and pushed.

[seamuslee001]

Jenkins ok to test

[mlutfy]

@mihaelmladenov That's a good improvement too, but I was talking about the "Delete Participants" action, it still has the top buttons as well:

Otherwise we're creating an inconsistency, by having Cancel and Delete behave differently.

[ghost]

@mlutfy This is now also fixed.