CRM-21456 : Relationship end date not set when creating resolved cases #11301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jitendrapurohit
force-pushed
the
CRM-21456
branch
from
9be353e
to
a181739
Compare
jitendrapurohit
force-pushed
the
CRM-21456
branch
from
a181739
to
3717c34
Compare
|
jenkins, retest this please |
| @@ -92,6 +92,11 @@ public static function &create(&$params) { | |||
| // CRM-20958 - These fields are managed by MySQL triggers. Watch out for clients resaving stale timestamps. | |||
| unset($params['created_date']); | |||
| unset($params['modified_date']); | |||
| $caseStatus = CRM_Case_PseudoConstant::caseStatus('name'); | |||
There was a problem hiding this comment.
please add a space before this line
|
Checked the code and did some UI testing and it looks okay, just left minor comment@jitendrapurohit |
|
I'm going to merge this based on @omarabuhussein review. I realise there is a stylistic comment outstanding but I don't want to hold up merge on it as I'm looking at it now and I think it's more a suggestion than a requirement |
sluc23
pushed a commit
to ixiam/civicrm-core
that referenced
this pull request
Jan 10, 2018
CRM-21456 : Relationship end date not set when creating resolved cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Set relationship end date while creating resolved cases.
Before
Relationship end date is not set when creating a new case with resolved status.
When a Resolved case is created via api(through explorer or via webform). Case end date is not automatically stored. It is correctly set from the "New Case" form.
See more details in jira issue.
After
Both the above issues are fixed.
Technical Details
This PR migrates the case end date calculation from
FormtoBAOlayer, so that it is executed from API too.Comments
Added unit test