CRM-21465 - avoid fatal error when clicking through pledge email.

[jmcclelland]

Overview

When setting up a pledge, an email message is sent with a link you can use to make a contribution against your pledge. When you click on this link, you get a backtrace.

Before

When clicking on the pledge link, you get a back trace.

After

When clicking on the link, you get a form to fill in your contribution amount.

Technical Details

This is a start - if I'm not missing anything obvious I can add a test. But for now, it seems that calling CRM_Core_DAO::commonRetrieveAll against a table with returnProperties set to a field that is not in the table shouldn't wor.

---

• CRM-21465: clicking on pledge link in email returns fatal error

[eileenmcnaughton]

@jmcclelland I feel like it would make the code more readable if we used the api rather than that retrieveAll function - which most people are less familiar with.

However, the main thing that is confusing me is why this error is not hit outside of this (ie. the pledge block can be on the normal contribution page can't it).

I do think wrapping a test around this function would rock!

[mlutfy]

@Edzelopez Could you review this PR? It seems like that line was added in dccd9f4

[twomice]

I can confirm this fixes the issue described in CRM-21465 and makes pledge payments possible again.

[eileenmcnaughton]

merging based on @twomice review. @Edzelopez / @monishdeb FYI - a fatal seems like an important reason to merge - you can revisit the reason for adding